Skip to content

Commit

Permalink
replace indirect call by direct call in modules
Browse files Browse the repository at this point in the history
  • Loading branch information
@szabgab
szabgab committed May 20, 2015
1 parent 45d8f7b commit ddf8762
Show file tree
Hide file tree
Showing 8 changed files with 36 additions and 36 deletions.
10 changes: 5 additions & 5 deletions lib/Pod/Tree/PerlBin.pm
View file
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,9 @@ sub index {

$perl_bin->mkdir("$html_dir/$bin_dir");

my $fh = new IO::File ">$dest";
my $fh = IO::File->new(">$dest");
defined $fh or die "Pod::Tree::PerlBin::index: Can't open $dest: $!\n";
my $stream = new HTML::Stream $fh;
my $stream = HTML::Stream->new($fh);

my $options = $perl_bin->{options};
my $bgcolor = $options->{bgcolor};
Expand Down Expand Up @@ -174,7 +174,7 @@ sub translate {
my $entry = $index->{$name};
my $source = $entry->{source};
my $dest = $entry->{dest};
my $html = new Pod::Tree::HTML $source, $dest, %$options;
my $html = Pod::Tree::HTML->new( $source, $dest, %$options );
$html->translate;
}
}
Expand All @@ -189,8 +189,8 @@ Pod::Tree::PerlBin - translate program PODs to HTML
=head1 SYNOPSIS
$perl_map = new Pod::Tree::PerlMap;
$perl_bin = new Pod::Tree::PerlBin $perl_dir, $HTML_dir, $perl_map, %opts;
$perl_map = Pod::Tree::PerlMap->new;
$perl_bin = Pod::Tree::PerlBin->new($perl_dir, $HTML_dir, $perl_map, %opts);
$perl_bin->scan(@path);
$perl_bin->index;
Expand Down
14 changes: 7 additions & 7 deletions lib/Pod/Tree/PerlDist.pm
View file
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,9 @@ sub index {
my $top_page = $perl_dist->{top_page};
my $dest = "$html_dir/$top_page";

my $fh = new IO::File ">$dest";
my $fh = IO::File->new(">$dest");
defined $fh or die "Pod::Tree::PerlDist::index: Can't open $dest: $!\n";
my $stream = new HTML::Stream $fh;
my $stream = HTML::Stream->new($fh);

my $options = $perl_dist->{options};
my $bgcolor = $options->{bgcolor};
Expand Down Expand Up @@ -171,7 +171,7 @@ sub translate_pod {
my $source = $entry->{source};
my $dest = $entry->{dest};
my $options = $perl_dist->{options};
my $html = new Pod::Tree::HTML $source, $dest, %$options;
my $html = Pod::Tree::HTML->new( $source, $dest, %$options );
$html->translate;
}

Expand All @@ -184,10 +184,10 @@ sub translate_text {
open( my $SOURCE, '<', $source )
or die "Pod::Tree::PerlDist::translate_text: Can't open $source: $!\n";

my $fh = new IO::File ">$dest";
my $fh = IO::File->new(">$dest");
defined $fh
or die "Pod::Tree::PerlDist::translate_text: Can't open $dest: $!\n";
my $stream = new HTML::Stream $fh;
my $stream = HTML::Stream->new($fh);

my $options = $perl_dist->{options};
my $bgcolor = $options->{bgcolor};
Expand Down Expand Up @@ -218,8 +218,8 @@ Pod::Tree::PerlDist - translate Perl distribution documentation to HTML
=head1 SYNOPSIS
$perl_map = new Pod::Tree::PerlMap;
$perl_dist = new Pod::Tree::PerlDist $perl_dir, $HTML_dir, $perl_map, %opts;
$perl_map = Pod::Tree::PerlMap->new;
$perl_dist = Pod::Tree::PerlDist->new( $perl_dir, $HTML_dir, $perl_map, %opts );
$perl_dist->scan;
$perl_dist->index;
Expand Down
14 changes: 7 additions & 7 deletions lib/Pod/Tree/PerlFunc.pm
View file
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ sub load_tree {
my $source = "$perl_dir/$pod_dir/$page.pod";
my $win_source = "$perl_dir/lib/$pod_dir/$page.pod";

my $tree = new Pod::Tree;
my $tree = Pod::Tree->new;
$tree->load_file($source) or # for building the doc set from a Perl distribution
$tree->load_file($win_source) or # for building the doc set from a Windows installation
die "Pod::Tree::PerlFunc::scan: Can't find $source or $win_source\n";
Expand Down Expand Up @@ -94,7 +94,7 @@ sub index {
$options->{link_map}->set_depth(1);

my $dest = "$html_dir/$pod_dir/$page.html";
my $html = new Pod::Tree::HTML $tree, $dest, %$options;
my $html = Pod::Tree::HTML->new( $tree, $dest, %$options );
$html->translate;
}

Expand Down Expand Up @@ -144,7 +144,7 @@ sub add_index {

my $pod = join "\n\n", @lines;

my $tree = new Pod::Tree;
my $tree = Pod::Tree->new;
$tree->load_string($pod);
my $children = $tree->get_root->get_children;

Expand Down Expand Up @@ -174,15 +174,15 @@ sub translate {
my ( $func, $file ) = Parse_Name( $items[0] );
$perl_func->report2("func/$file");

my $tree = new Pod::Tree;
my $tree = Pod::Tree->new;
$tree->load_string("=head1 $func\n\n=over 4\n\n=back");
my $list = $tree->get_root->get_children->[1];
$list->set_children( \@items );
$list->_set_list_type;

$options->{title} = $func;
my $dest = "$html_dir/$pod_dir/$func_dir/$file.html";
my $html = new Pod::Tree::HTML $tree, $dest, %$options;
my $html = Pod::Tree::HTML->new( $tree, $dest, %$options );
$html->translate;
}

Expand Down Expand Up @@ -230,8 +230,8 @@ Pod::Tree::PerlFunc - translate F<perlfunc.pod> to HTML
=head1 SYNOPSIS
$perl_map = new Pod::Tree::PerlMap;
$perl_func = new Pod::Tree::PerlFunc $perl_dir, $HTML_dir, $perl_map, %opts;
$perl_map = Pod::Tree::PerlMap->new;
$perl_func = Pod::Tree::PerlFunc->new($perl_dir, $HTML_dir, $perl_map, %opts);
$perl_func->scan;
$perl_func->index;
Expand Down
10 changes: 5 additions & 5 deletions lib/Pod/Tree/PerlLib.pm
View file
Original file line number Diff line number Diff line change
Expand Up @@ -132,9 +132,9 @@ sub index {
my $top_page = $perl_lib->{top_page};
my $dest = "$html_dir/$top_page";

my $fh = new IO::File ">$dest";
my $fh = IO::File->new(">$dest");
defined $fh or die "Pod::Tree::PerlLib::index: Can't open $dest: $!\n";
my $stream = new HTML::Stream $fh;
my $stream = HTML::Stream->new($fh);

my $options = $perl_lib->{options};
my $bgcolor = $options->{bgcolor};
Expand Down Expand Up @@ -205,7 +205,7 @@ sub translate {
my $entry = $index->{$name};
my $source = $entry->{source};
my $dest = $entry->{dest};
my $html = new Pod::Tree::HTML $source, $dest, %$options;
my $html = Pod::Tree::HTML->new( $source, $dest, %$options );
$html->translate;
}
}
Expand All @@ -220,8 +220,8 @@ Pod::Tree::PerlLib - translate module PODs to HTML
=head1 SYNOPSIS
$perl_map = new Pod::Tree::PerlMap;
$perl_lib = new Pod::Tree::PerlLib $perl_dir, $HTML_dir, $perl_map, %opts;
$perl_map = Pod::Tree::PerlMap->new;
$perl_lib = Pod::Tree::PerlLib->new( $perl_dir, $HTML_dir, $perl_map, %opts );
$perl_lib->scan(@INC);
$perl_lib->index;
Expand Down
10 changes: 5 additions & 5 deletions lib/Pod/Tree/PerlPod.pm
View file
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,9 @@ sub index {
my $top_page = $perl_pod->{top_page};
my $dest = "$html_dir/$top_page";
my $fh = new IO::File ">$dest";
my $fh = IO::File->new(">$dest");
defined $fh or die "Pod::Tree::PerlPod::index: Can't open $dest: $!\n";
my $stream = new HTML::Stream $fh;
my $stream = HTML::Stream->new($fh);
my $options = $perl_pod->{options};
my $bgcolor = $options->{bgcolor};
Expand Down Expand Up @@ -185,7 +185,7 @@ sub _translate {
my $depth = @path - 1;
$options->{link_map}->set_depth($depth);
my $html = new Pod::Tree::HTML $source, $dest, %$options;
my $html = Pod::Tree::HTML->new( $source, $dest, %$options );
$html->translate;
}
Expand All @@ -199,8 +199,8 @@ Pod::Tree::PerlPod - translate Perl PODs to HTML
=head1 SYNOPSIS
$perl_map = new Pod::Tree::PerlMap;
$perl_pod = new Pod::Tree::PerlPod $perl_dir, $HTML_dir, $perl_map, %opts;
$perl_map = Pod::Tree::PerlMap->new;
$perl_pod = Pod::Tree::PerlPod->new( $perl_dir, $HTML_dir, $perl_map, %opts );
$perl_pod->scan;
$perl_pod->index;
Expand Down
10 changes: 5 additions & 5 deletions lib/Pod/Tree/PerlTop.pm
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ sub index {
my $html_dir = $perl_top->{html_dir};
my $dest = "$html_dir/index.html";

my $fh = new IO::File ">$dest";
my $fh = IO::File->new(">$dest");
defined $fh or die "Pod::Tree::PerlTop::index: Can't open $dest: $!\n";
my $stream = new HTML::Stream $fh;
my $stream = HTML::Stream->new($fh);

my $options = $perl_top->{options};
my $bgcolor = $options->{bgcolor};
Expand Down Expand Up @@ -88,7 +88,7 @@ sub translate {
my $page = $perl_top->{page};
my $source = "$perl_dir/$pod_src/$page.pod";
my $dest = "$html_dir/$pod_dst/$page.html";
my $html = new Pod::Tree::HTML::PerlTop $source, $dest, %$options;
my $html = Pod::Tree::HTML::PerlTop->new( $source, $dest, %$options );
my $links = $perl_top->_get_links;

$html->set_links($links);
Expand Down Expand Up @@ -165,8 +165,8 @@ Pod::Tree::PerlTop - generate a top-level index for Perl PODs
=head1 SYNOPSIS
$perl_map = new Pod::Tree::PerlMap;
$perl_top = new Pod::Tree::PerlTop $perl_dir, $HTML_dir, $perl_map, %opts;
$perl_map = Pod::Tree::PerlMap->new;
$perl_top = Pod::Tree::PerlTop->new( $perl_dir, $HTML_dir, $perl_map, %opts );
$perl_top->index(@translators);
$perl_top->translate;
Expand Down
2 changes: 1 addition & 1 deletion lib/Pod/Tree/PerlUtil.pm
View file
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ sub report2 {
sub get_name {
my ( $node, $source ) = @_;

my $tree = new Pod::Tree;
my $tree = Pod::Tree->new;
$tree->load_file($source);
my $children = $tree->get_root->get_children;
my @pod = grep { is_pod $_ } @$children;
Expand Down
2 changes: 1 addition & 1 deletion lib/Pod/Tree/Pod.pm
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ sub _resolve_dest {

ref $dest and return $dest;

my $fh = new IO::File;
my $fh = IO::File->new;
$fh->open(">$dest") or die "Pod::Tree::Pod::new: Can't open $dest: $!\n";
$fh;
}
Expand Down

0 comments on commit ddf8762

Please sign in to comment.