create html folder if doesn't exist #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 36
💛 - Coveralls |
|
Thanks. Please also add a test covering the new code. |
|
How do I do that? The test case is not having an html folder in the slides repo. |
|
Write a test case that would try to put the html files in a subdirectory of tmpdir (e.g. call it abcd just to make sure we don't overuse the 'html' string) and check if that works properly. |
szabgab
reviewed
Feb 21, 2018
| root = str(tmpdir) | ||
| target_dir = os.path.join(root, 'abcd') | ||
| generate_html_files(self, target_dir) | ||
| assert os.path.exists(target_dir) == 1 |
There was a problem hiding this comment.
One minor thing. this should be
assert os.path.exists(target_dir)
as that method returns True/False
|
Merged and I made that change myself. |
|
Thanks |
|
Got it. Thanks for the explanation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.