Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies for the examples #1

Merged

Conversation

anderslindho
Copy link

I noticed that numpy was a requirement to use this library.

I suppose that pyglet also could be added to this list, but since it technically only is used for the examples that part was less clear to me. I could add it to this MR as an optional feature if you'd like (through use of extras_requires).

@szabolcsdombi
Copy link
Owner

We use numpy in a lot of examples, but zengl itself does not depend on numpy. There are other libraries that can generate buffer data or simple file content is also sufficient. I really like using numpy and it is really well known.

The only dependency at the moment is glcontext which has no other open-source alternative yet.
ZenGL itself has 0 dependencies and it has a really small package size as well.
(this is important for the headless mode in a custom environment. also good for my upcoming raspberry pi test)

I like the idea of having extras_requires with glcontext and numpy at least, but it would be great to have all the dependencies of the examples.

A MR would be welcome for the extras_requires.
Thank you.

@szabolcsdombi
Copy link
Owner

Also pyglet is a dependency for most of the examples.

@anderslindho anderslindho force-pushed the add_numpy_to_setuptools_conf branch 2 times, most recently from c12fa4d to d5a8902 Compare November 13, 2021 16:53
@anderslindho
Copy link
Author

Like this or do you want glcontext as an install_requires?

Also, should I close this MR and add one with updated title+description or is this fine?

@szabolcsdombi
Copy link
Owner

This is fine, I update the readme soon to have this pip install offered too.

Is it pip install zengl[examples]?

@szabolcsdombi szabolcsdombi changed the title Add numpy as dependency Dependencies for the examples Nov 13, 2021
@anderslindho
Copy link
Author

Correct

@szabolcsdombi szabolcsdombi merged commit e759f04 into szabolcsdombi:main Nov 13, 2021
@szabolcsdombi
Copy link
Owner

Thank you for your contribution

szabolcsdombi added a commit that referenced this pull request Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants