Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate clearly that building was successful #2

Closed
Tobychev opened this issue Mar 7, 2014 · 6 comments
Closed

Indicate clearly that building was successful #2

Tobychev opened this issue Mar 7, 2014 · 6 comments

Comments

@Tobychev
Copy link
Contributor

Tobychev commented Mar 7, 2014

Currently building the example (using compiler=GNU), results in two lines being printed, the last one being a call to the compiler typeset in red. It is not obvious that this indicates a successful build.

@szaghi
Copy link
Owner

szaghi commented Mar 8, 2014

Thanks Tobychev,
you are right, it is better to be more verbose in some cases :-)

I am trying to optimize parallel compilations, after that I will improve the script CLI.

@szaghi
Copy link
Owner

szaghi commented Mar 10, 2014

Hi Tobychev,

I have just improved the CLI (besides other improvements...); is it ok now?

@Tobychev
Copy link
Contributor Author

Tobychev commented Apr 4, 2014

Hello szahi, sorry for taking so long with replying.

I do like that the build settings are printed at the end of the build. However they are printed after the result of the build, so it is harder than it should be to see if a build succeed. I think the built result should be the very last thing printed before you return to the shell, after all the prompt is the only place guaranteed to end up on the screen of the user.

@szaghi
Copy link
Owner

szaghi commented Apr 5, 2014

Hi Tomas you are right. Monday I will change the CLI. Thank you
Il 05/apr/2014 00:25 "Tomas Bylund" notifications@github.com ha scritto:

Hello szahi, sorry for taking so long with replying.

I do like that the build settings are printed at the end of the build.
However they are printed after the result of the build, so it is harder
than it should be to see if a build succeed. I think the built result
should be the very last thing printed before you return to the shell, after
all the prompt is the only place guaranteed to end up on the screen of the
user.

Reply to this email directly or view it on GitHubhttps://github.com//issues/2#issuecomment-39617714
.

@szaghi
Copy link
Owner

szaghi commented Apr 7, 2014

Hi Tomas,

I have modified the CLI. Presently the build settings are the first message echoed, while the last is the ultimate, successful linked target. It is worthy of note that I have also tried to address the bug on capturing compilation error: now, if one file is not successfully compiled, FoBiS.py tracks it and the building ends immediately with a clear indication of which file has not been compiled.

@Tobychev
Copy link
Contributor Author

Tobychev commented Apr 8, 2014

Hello Stefano,
thank you, this is clearer :)

@Tobychev Tobychev closed this as completed Apr 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants