various cleanups and GPU code. #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ addressed several signed/unsigned comparison issues which can lead
to undefined behavior in overflow conditions
+ removed unrequited ';' after functions because they generate
compiler warnings
+ all the use of C++ in the openmp header by using extern "C" behind a
pre-processor macro. This will allow but not require the use of C++
templates and other code that has the potential to simplify code in
the near future.
+ removed numerous dead/unused variables as they just add to cognitive
burden in reading the code
+ silenced erroneous compiler warning about char subscripts
+ fixed printf format flags to represent the actual type of the
printed variable as this can cause undefined behavior
+ remove reference to private zlib header <zutil.h> because this makes
it possible to compile SZ on more platforms that don't install the
private headers
+ remove printf statements in the library protions of the code not
protected by `#ifdef DEBUG` guards because they slow down
performance benchmarking
+ Began work on a GPU implementation
+ Add additional "{" and "}" to silence ambiguous parent warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the beginnings of the GPU code can be found in
src/sz/sz_cuda.cu.