Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Move Language, Theme & Debug into Config or Settings #10

Closed
moritz-t-w opened this issue Jan 17, 2024 · 6 comments
Closed

[feat] Move Language, Theme & Debug into Config or Settings #10

moritz-t-w opened this issue Jan 17, 2024 · 6 comments
Labels
feature New feature or request

Comments

@moritz-t-w
Copy link

I think Language, Theme and Debug don't belong in the top bar.
It would look less overwhelming if they were all inside of the Config submenu
mockup with language & debug
In fact, changing the language is such an infrequent use case that I think it belongs in the Settings:
mockup with debug
The Debug config is also not something the average user will use, so I think it could also be in Settings.
mockup without either

@moritz-t-w
Copy link
Author

If you agree, I will implement whichever solution turns out to fit best :)

@szczyglis-dev
Copy link
Owner

Sure, I agree, you can go ahead :)
I also think that the clearest option will be the last one, which is moving Theme to Config, and Language and Debug to Settings.

@szczyglis-dev szczyglis-dev added the feature New feature or request label Jan 18, 2024
@moritz-t-w
Copy link
Author

Ok I will get to work on this. Could you just assign it to me so I can keep track of it?

@moritz-t-w
Copy link
Author

So.. tbh I thought this would be a lot less complicated lol. I don't think I have the capacity atm to dive into the code, sorry. :<

@szczyglis-dev
Copy link
Owner

Oops, I didn't assign you to this task, sorry about that (too many things to juggle at once and I missed it).
No worries, it's OK. If that's the case, I'll just handle it on my own in one of the upcoming updates ;)

@szczyglis-dev
Copy link
Owner

Added in release 2.0.116 ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants