Refactor get_sites() extension to improve readability

[IanDelMar]

Refactors the dynamic function return type extension for get_sites() to improve readability.

Last PR addressing this extension 😇

[szepeviktor]

Hello good-old pass-by-ref :(
This is sooo PHP4!

Please use properties for passing data around.

[IanDelMar]

@szepeviktor I switched to properties and now 15 assertions fail. 😞 I'll need some time to figure out what's going on.

[herndlm]

Properties add state to those classes making them mutable. Could be that one line of analysed code sets a property that is then incorrectly used for another line of analysed code?

[IanDelMar]

I replaced $count with $this->fields... 😆

[herndlm]

Just one more thing though. A get* method that doesn't return anything but changes some state is one of the things that keeps me from sleeping at night xD

Most likely the simplest and safest thing is just to return the relevant values as an array and type it for phpstan with an array shape. You can use it in a sane way via e.g. [$foo, $bar] = $this->getSomething(). Assuming that Viktor isn't still supporting php and WordPress from 10 years ago here xD

[herndlm]

OK too slow 😅 as long as it works

[szepeviktor]

that keeps me from sleeping at night

Mine is get_template_part that is really print_template_part.

[herndlm]

Oh no, stop it...

[szepeviktor]

@herndlm Please star my next gen WordPress: https://github.com/szepeviktor/WordPress-the-good-parts

[IanDelMar]

@herndlm you're right. I'll rename the method when I remove the query string argument support (#159).

[herndlm]

Viktor stop trying to sell me your passive aggressive empty repo 😅