Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dynamic return type extension for wp_die() #204

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Fix dynamic return type extension for wp_die() #204

merged 3 commits into from
Oct 16, 2023

Conversation

IanDelMar
Copy link
Contributor

@IanDelMar IanDelMar commented Oct 16, 2023 •
edited

Fixes #203
Adds missing tests (#203 (comment))

@IanDelMar IanDelMar changed the title Add missing tests for wp_die() Fix dynamic return type extension for wp_die() Oct 16, 2023
@IanDelMar
Copy link
Contributor Author

@szepeviktor NonAcceptingNeverType requires PHPStan 1.10.30

@herndlm
Copy link
Contributor

herndlm commented Oct 16, 2023

Bump it Victor, bump it! :)

@szepeviktor szepeviktor merged commit b8516ed into szepeviktor:master Oct 16, 2023
0 of 2 checks passed
@szepeviktor
Copy link
Owner

requires PHPStan 1.10.30

With 1.10.30 it fails to find NonAcceptingNeverType
https://app.travis-ci.com/github/szepeviktor/phpstan-wordpress/jobs/611654029

@szepeviktor
Copy link
Owner

It is https://github.com/phpstan/phpstan/releases/tag/1.10.31 :(

@IanDelMar IanDelMar deleted the wp-die branch October 16, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wp_die() doesn't end script anymore
3 participants
@IanDelMar @herndlm @szepeviktor