Optional onChange skip when setting/toggling state

A state change could cause infinite loop if used within the onChange function, e.g. when a remote call failed and the state of the button should reset.
sziep · Oct 15, 2012 · 2ff9821 · 2ff9821
1 parent 5ea2f80
commit 2ff9821
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/static/js/jquery.toggle.buttons.js b/static/js/jquery.toggle.buttons.js
@@ -128,7 +128,7 @@
                 changeStatus($(this));
               });
 
-              $('.toggle-button').find('input').on('change', function (e) {
+              $('.toggle-button').find('input').on('change', function (e, skipOnChange) {
                 var $element = $(this).parent()
                   , active = $(this).is(':checked')
                   , $toggleButton = $(this).closest('.toggle-button');
@@ -139,7 +139,9 @@
                 $element.stop().animate({'left': active ? '0' : '-50%'}, $toggleButton.data('transitionSpeed'));
 
                 options = $toggleButton.data('options');
-                options.onChange($element, active, e);
+
+                if (!skipOnChange)
+                  options.onChange($element, active, e);
               });
 
               $('.toggle-button').find('label').on('mousedown', function (e) {
@@ -212,12 +214,12 @@
         toggleActivation: function () {
           $(this).toggleClass('deactivate');
         },
-        toggleState: function () {
+        toggleState: function (skipOnChange) {
           var $input = $(this).find('input');
-          $input.attr('checked', !$input.is(':checked')).trigger('change')
+          $input.attr('checked', !$input.is(':checked')).trigger('change', skipOnChange)
         },
-        setState: function(value) {
-          $(this).find('input').attr('checked', value).trigger('change')
+        setState: function(value, skipOnChange) {
+          $(this).find('input').attr('checked', value).trigger('change', skipOnChange)
         }
       };