Export to SVG with correct pen colors #260
Conversation
| @@ -404,7 +406,7 @@ SignaturePad.prototype._toSVG = function () { | |||
|
|
|||
| path.setAttribute('d', attr); | |||
| path.setAttribute('stroke-width', (widths.end * 2.25).toFixed(3)); | |||
| path.setAttribute('stroke', this.penColor); | |||
| path.setAttribute('stroke', color); | |||
There was a problem hiding this comment.
If there's no default value for color here (and for drawing dots as well), will it work with the existing exported SVG strings? Won't it set color to undefined?
There was a problem hiding this comment.
Let's test and see...
There was a problem hiding this comment.
So this works:
- Create a design with multiple colors.
- Export to SVG saves design with correct color combinations.
- Import from the same SVG shows color combinations correctly.
What doesn't work:
At that point you cannot export to SVG again using 2.1.1 even without the proposed change since the SVG export feature relies on recording the strokes to the this._data array.
The only solution I see would be to repopulate the this._data array by reinterpreting the imported SVG data instead of relying on the canvas itself to draw the imported data.
There was a problem hiding this comment.
Thanks! I've added a note in the README that calling #toData won't really work if signature was loaded using #fromDataURL.
Hey @szimek this is a simple modification to export to SVG with the correct pen color for each stroke.