Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Anonymous to crossOrigin prop #542

Conversation

pxwee5
Copy link
Contributor

@pxwee5 pxwee5 commented Jun 4, 2021

Discussion: #399
Tested and it works for my setup. What do we need to get this through ? @szimek

src/signature_pad.ts Outdated Show resolved Hide resolved
Co-authored-by: Tony Brix <tony@brix.ninja>
@UziTech UziTech requested a review from szimek June 4, 2021 04:59
@szimek szimek merged commit 567bbcf into szimek:master Jun 4, 2021
@pxwee5
Copy link
Contributor Author

pxwee5 commented Jun 7, 2021

@szimek Thanks for merging the code.
Any plans to do a patch release in v2.x.x ?

@szimek
Copy link
Owner

szimek commented Jun 13, 2021

@pxwee5 Yeah, thought it's really hard to say when exactly. Do you have a list of bug fixes that were merged into 3.x branch that you'd like to have in 2.x release? This would help a lot!

@pxwee5
Copy link
Contributor Author

pxwee5 commented Jun 13, 2021

Hey @szimek. I'm not aware of any other bug that was fixed in v3 that needs to be in v2. If there are any that you think should fix v2 we should definitely list them out.
But in my opinion, the crossOrigin fix alone is critical enough to warrant a patch fix for v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants