-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capture pressure when signing #566
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I hope it works ;)
I'm wondering if we could make some of the properties (e.g. _data
) public, or rather stop pretending they are private, or provide getters for them, and document them properly. This would allow us to create toWhateverFormat
-type function either as a separate function (e.g. toSvg(signaturePad.data)
, toIsoData(signaturePad.data)
that wouldn't have to be loaded if not used, or even as a third-party add-on library.
Also, I just realized that if we stopped supporting Safari 12 and earlier, we could handle pointer events only... However, it might still be too early - I don't know what types of projects this library is used in.
Should I remove the |
I forgot about I think it would be a good idea to extract it. I'm just wondering about API - if these |
One of my next changes was going to put more of those properties into the point groups so we can save information like max/min width and dot size, etc. per line segment. (PR #571) I feel like toData() should give all of the properties. |
update of #503
closes #503
closes #213
closes #379