Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use event emitter #567

Merged
merged 2 commits into from Nov 17, 2021
Merged

use event emitter #567

merged 2 commits into from Nov 17, 2021

Conversation

UziTech
Copy link
Collaborator

@UziTech UziTech commented Nov 15, 2021 •
edited

  • Remove callback for fromDataUrl and return promise instead.
  • Remove onBegin option and add beginStroke event.
  • Remove onEnd options and add endStroke event.
  • add beforeUpdateStroke and afterUpdateStroke events.

fixes #543
closes #423

@UziTech UziTech linked an issue Nov 15, 2021 that may be closed by this pull request
Make signature_pad an event emitter #543
Closed
@UziTech UziTech requested a review from szimek November 15, 2021 01:25
szimek
szimek approved these changes Nov 16, 2021
View reviewed changes
Copy link
Owner

@szimek szimek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! 🎉

The only small issue is that this will break IE compatibility, but I think it's ok to do in a major release. I'm wondering if we should just skip 3.0 release given that the last 3.x beta was released in 2018 and go straight to 4.x.

@UziTech
Copy link
Collaborator Author

UziTech commented Nov 16, 2021

Ya I don't think we should continue to support IE given Microsoft hasn't supported it in a while.

I think going to v4 would be fine.

@UziTech UziTech merged commit a465b6c into szimek:master Nov 17, 2021
@UziTech UziTech deleted the event-emitter branch November 17, 2021 05:42
@UziTech UziTech mentioned this pull request Nov 18, 2021
Closed
@bowozer bowozer mentioned this pull request Dec 8, 2021
Closed
@bowozer bowozer mentioned this pull request Dec 15, 2021
Merged
@JamesRobertWiseman JamesRobertWiseman mentioned this pull request Jan 19, 2022
Closed
@AlbertoMontalesi AlbertoMontalesi mentioned this pull request Mar 14, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szimek szimek szimek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make signature_pad an event emitter
2 participants
@UziTech @szimek