changelog: add breaking change to v4's dotSize
#616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this was changed to only accept a number, whereas it previously accepted a number or a function - this was necessary in order to serialize dotSize in #toData - found this while exploring an upgrade
|
🎉 This PR is included in version 4.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add note to v4.0.0 changelog that
dotSizehad a breaking change as wellDetails
this was changed to only accept a
number, whereas it previously accepted anumberor afunctiondotSizein#toDatain save line properties in point groups #571found this line diff while exploring an upgrade in Bump signature_pad to v4 to fix
undefined is not an objectrace condition agilgur5/react-signature-canvas#68 (comment)Review Notes
There might be more breaking changes missing from the Changelog? c.f. agilgur5/react-signature-canvas#68 (comment)