Fix receiving trailers

szmarczak · Aug 13, 2018 · e189406 · e189406
1 parent 8d7febd
commit e189406
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/source/HTTP2ClientRequest.js b/source/HTTP2ClientRequest.js
@@ -187,8 +187,8 @@ class HTTP2ClientRequest extends Writable {
 			});
 
 			this._request.on('trailers', (trailers, flags, rawTrailers) => {
-				self.res.trailers = trailers;
-				self.res.rawTrailers = rawTrailers;
+				Object.assign(self.res.trailers, trailers);
+				Object.assign(self.res.rawTrailers, rawTrailers);
 			});
 
 			if (!this[kCustomSession]) {

diff --git a/source/HTTP2IncomingMessage.js b/source/HTTP2IncomingMessage.js
@@ -13,7 +13,7 @@ class HTTP2IncomingMessage extends Readable {
 		this.httpVersionMajor = 2;
 		this.httpVersionMinor = 0;
 		this.headers = response.headers;
-		this.trailers = [];
+		this.trailers = {};
 		this.req = req;
 
 		this.aborted = false;

diff --git a/test/request.js b/test/request.js
@@ -44,6 +44,7 @@ test('can provide custom session', async t => {
 
 	const res = await pEvent(req, 'response');
 	res.resume();
+	session.close();
 	t.pass();
 });