Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove event listeners on the response end event #34

Closed
szmarczak opened this issue Mar 23, 2020 · 1 comment
Closed

Remove event listeners on the response end event #34

szmarczak opened this issue Mar 23, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@szmarczak
Copy link
Owner

szmarczak commented Mar 23, 2020 •
edited

http2-wrapper/source/client-request.js

Line 222 in 6058e1f

proxyEvents(stream, this, ['timeout', 'continue', 'close', 'error']);

I think that's the reason the Windows test fails: the stream may emit error after end (need to verify that).

A note to myself: check previous builds.
@szmarczak szmarczak added the bug Something isn't working label Mar 23, 2020
@szmarczak
Copy link
Owner Author

szmarczak commented Mar 24, 2020 •
edited

But that would lead to uncaught and unattached errors... The tests are fixed now, there was yet another reason for failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@szmarczak