This repository has been archived by the owner on Jun 29, 2021. It is now read-only.
WIP: Discriminators #333
Closed
WIP: Discriminators #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 16, 2019
hasezoey
force-pushed
the
discriminator
branch
3 times, most recently
from
da938f6
to
877c8f7
Compare
|
Closed in favor of typegoose/typegoose#11 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work In Progress ... when the test problem is fixed
Why already an Pull request
Because I have done something that i wanted to show for #332, but i currently hang on the first test of
getClassForDocument(), because i changed some things, this one dosnt work anymore, so i wanted feedback & resolve proposals ...Note: I know i didnt rebase on the master branch, but i currently only want to show, and wait for #331 to be merged
What it currently does:
getClassForDocument()'s first testNote: this is just a quick model of how this could work, but currently it breaks some things
PS: when i find a solution to the test, and other coming up problems, i probably rework this pr