Skip to content

Commit

Permalink
[#48] Upgrade to Gradle 2.14.1
Browse files Browse the repository at this point in the history
Remove reference to Guava which is not leaking from Gradle anymore.

Fixes #48.
  • Loading branch information
szpak committed Aug 14, 2016
1 parent 473316f commit 6179628
Show file tree
Hide file tree
Showing 6 changed files with 45 additions and 38 deletions.
Binary file modified gradle/wrapper/gradle-wrapper.jar
Binary file not shown.
6 changes: 3 additions & 3 deletions gradle/wrapper/gradle-wrapper.properties
@@ -1,7 +1,7 @@
#Fri Mar 18 21:02:53 CET 2016
#Mon Aug 15 00:38:44 CEST 2016
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-2.12-all.zip
distributionSha256Sum=d8b1948a575dc9ec13e03db94502ce91815d73da023f611296c04b852164cb5f
distributionUrl=https\://services.gradle.org/distributions/gradle-2.14.1-bin.zip
distributionSha256Sum=cfc61eda71f2d12a572822644ce13d2919407595c2aec3e3566d2aab6f97ef39
46 changes: 25 additions & 21 deletions gradlew
Expand Up @@ -6,12 +6,30 @@
##
##############################################################################

# Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
DEFAULT_JVM_OPTS=""
# Attempt to set APP_HOME
# Resolve links: $0 may be a link
PRG="$0"
# Need this for relative symlinks.
while [ -h "$PRG" ] ; do
ls=`ls -ld "$PRG"`
link=`expr "$ls" : '.*-> \(.*\)$'`
if expr "$link" : '/.*' > /dev/null; then
PRG="$link"
else
PRG=`dirname "$PRG"`"/$link"
fi
done
SAVED="`pwd`"
cd "`dirname \"$PRG\"`/" >/dev/null
APP_HOME="`pwd -P`"
cd "$SAVED" >/dev/null

APP_NAME="Gradle"
APP_BASE_NAME=`basename "$0"`

# Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
DEFAULT_JVM_OPTS=""

# Use the maximum available, or set MAX_FD != -1 to use that value.
MAX_FD="maximum"

Expand All @@ -30,6 +48,7 @@ die ( ) {
cygwin=false
msys=false
darwin=false
nonstop=false
case "`uname`" in
CYGWIN* )
cygwin=true
Expand All @@ -40,26 +59,11 @@ case "`uname`" in
MINGW* )
msys=true
;;
NONSTOP* )
nonstop=true
;;
esac

# Attempt to set APP_HOME
# Resolve links: $0 may be a link
PRG="$0"
# Need this for relative symlinks.
while [ -h "$PRG" ] ; do
ls=`ls -ld "$PRG"`
link=`expr "$ls" : '.*-> \(.*\)$'`
if expr "$link" : '/.*' > /dev/null; then
PRG="$link"
else
PRG=`dirname "$PRG"`"/$link"
fi
done
SAVED="`pwd`"
cd "`dirname \"$PRG\"`/" >/dev/null
APP_HOME="`pwd -P`"
cd "$SAVED" >/dev/null

CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar

# Determine the Java command to use to start the JVM.
Expand All @@ -85,7 +89,7 @@ location of your Java installation."
fi

# Increase the maximum file descriptors if we can.
if [ "$cygwin" = "false" -a "$darwin" = "false" ] ; then
if [ "$cygwin" = "false" -a "$darwin" = "false" -a "$nonstop" = "false" ] ; then
MAX_FD_LIMIT=`ulimit -H -n`
if [ $? -eq 0 ] ; then
if [ "$MAX_FD" = "maximum" -o "$MAX_FD" = "max" ] ; then
Expand Down
6 changes: 3 additions & 3 deletions gradlew.bat
Expand Up @@ -8,14 +8,14 @@
@rem Set local scope for the variables with windows NT shell
if "%OS%"=="Windows_NT" setlocal

@rem Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
set DEFAULT_JVM_OPTS=

set DIRNAME=%~dp0
if "%DIRNAME%" == "" set DIRNAME=.
set APP_BASE_NAME=%~n0
set APP_HOME=%DIRNAME%

@rem Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
set DEFAULT_JVM_OPTS=

@rem Find java.exe
if defined JAVA_HOME goto findJavaFromJavaHome

Expand Down
10 changes: 4 additions & 6 deletions src/main/groovy/info/solidsoft/gradle/pitest/PitestPlugin.groovy
Expand Up @@ -16,14 +16,13 @@
package info.solidsoft.gradle.pitest

import groovy.transform.PackageScope
import org.gradle.api.Project
import org.gradle.api.Plugin
import org.gradle.api.Project
import org.gradle.api.file.FileCollection
import org.gradle.api.internal.file.UnionFileCollection
import org.gradle.api.logging.Logger
import org.gradle.api.logging.Logging
import org.gradle.api.plugins.JavaBasePlugin
import org.gradle.api.file.FileCollection
import org.gradle.api.internal.file.UnionFileCollection
import com.google.common.annotations.VisibleForTesting

/**
* The main class for Pitest plugin.
Expand All @@ -36,8 +35,7 @@ class PitestPlugin implements Plugin<Project> {

private final static Logger log = Logging.getLogger(PitestPlugin)

@VisibleForTesting
@PackageScope
@PackageScope //visible for testing
final static String PIT_HISTORY_DEFAULT_FILE_NAME = 'pitHistory.txt'

private Project project
Expand Down
15 changes: 10 additions & 5 deletions src/main/groovy/info/solidsoft/gradle/pitest/PitestTask.groovy
Expand Up @@ -15,10 +15,15 @@
*/
package info.solidsoft.gradle.pitest

import groovy.transform.CompileStatic;
import groovy.transform.CompileStatic
import groovy.transform.PackageScope
import org.gradle.api.file.FileCollection
import org.gradle.api.tasks.*
import com.google.common.annotations.VisibleForTesting
import org.gradle.api.tasks.Input
import org.gradle.api.tasks.InputFiles
import org.gradle.api.tasks.JavaExec
import org.gradle.api.tasks.Optional
import org.gradle.api.tasks.OutputDirectory
import org.gradle.api.tasks.OutputFile

/**
* Gradle task implementation for Pitest.
Expand Down Expand Up @@ -179,7 +184,7 @@ class PitestTask extends JavaExec {
super.exec()
}

@VisibleForTesting
@PackageScope //visible for testing
Map<String, String> createTaskArgumentMap() {
Map<String, String> map = [:]
map['sourceDirs'] = (getSourceDirs()*.path)?.join(',')
Expand Down Expand Up @@ -240,7 +245,7 @@ class PitestTask extends JavaExec {
}
}

@VisibleForTesting
@PackageScope //visible for testing
List<String> createMultiValueArgsAsList() {
//It is a duplication/special case handling, but a PoC implementation with emulated multimap was also quite ugly and in addition error prone
getPluginConfiguration()?.collect { k, v ->
Expand Down

0 comments on commit 6179628

Please sign in to comment.