Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build and bugs around VPCID handling #21

Merged
merged 1 commit into from
Mar 22, 2019
Merged

Fix build and bugs around VPCID handling #21

merged 1 commit into from
Mar 22, 2019

Conversation

mikkeloscar
Copy link
Collaborator

This fixes several things.

  • Fixes the build which broke in fix: Only works with default VPC #20
  • Correctly sets the vpcID such that it's used when getting listing Internet Gateways
  • Adds a check to prevent crashing in case no Internet Gateways are found
  • Prevent caching during bootstrap which would prevent the controller from doing anything if started after a configmap with egress config is already in the cluster before the controller is started.
  • Updates to use Go modules

Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
@mikkeloscar
Copy link
Collaborator Author

👍

@szuecs
Copy link
Owner

szuecs commented Mar 22, 2019

👍

@szuecs szuecs merged commit 7d37881 into master Mar 22, 2019
@szuecs szuecs deleted the fix-build branch March 22, 2019 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants