Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should insertExistingMentions be made public? #32

Closed
raphaelcruzeiro opened this issue Jan 25, 2017 · 4 comments
Closed

Should insertExistingMentions be made public? #32

raphaelcruzeiro opened this issue Jan 25, 2017 · 4 comments
Labels

Comments

@raphaelcruzeiro
Copy link
Contributor

I'm trying to initialise the SZMentionsListener with a preexisting list of mentions. I found the insertExistingMentions method which seems to do what I want but the method is inaccessible from outside of the framework. Is this by design or should this method be made public?

@szweier
Copy link
Owner

szweier commented Jan 25, 2017

@raphaelcruzeiro you are absolutely correct this should be made public. I just opened a PR to fix this. Thanks for reporting the issue.

@raphaelcruzeiro
Copy link
Contributor Author

Somewhat related to this: After initialising the textView with a text and inserting the existing mentions on the SZMentionsListener, the mention attributes are not applied (though it seems at the mention is correctly added to the mention list of the listener). Am I missing some step here?

@szweier
Copy link
Owner

szweier commented Jan 25, 2017

@raphaelcruzeiro sorry for the delay, it should be working. I've added it to the PR mentioned above as part of the example app. Please let me know if that example helps.

@szweier
Copy link
Owner

szweier commented Jan 26, 2017

@raphaelcruzeiro version 1.0.2 should have what you're looking for.

@szweier szweier added the bug label Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants