Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When Capitalization for sentences is enabled, After entering first digit Capitalization is not disabled when using GBoard. #79

Closed
asim1mehta opened this issue Aug 20, 2018 · 2 comments
Assignees

Comments

@asim1mehta
Copy link

It happens only when using GBoard.

I guess it is happening because the text field is being reset.

It does not happen if we do not reset the text field when replacementText.count == 1, both in shouldAdjust(_ textView: UITextView, range: NSRange, text: String) and textView(_ textView: UITextView, shouldChangeTextIn range: NSRange, replacementText text: String) -> Bool

@szweier
Copy link
Owner

szweier commented Oct 12, 2018

@asim1mehta I may try to take a look at this at some point, but given that it involves use of an additional library I'm going to prioritize it a little lower than other issues. Feel free to open a PR with a solution and I'll take a look.

@szweier
Copy link
Owner

szweier commented Mar 24, 2019

@asim1mehta I apologize for the delay. I've just tried out Gboard and I don't see the problem. Have my recent changes to the library resolved this issue for you? The testing I did was to run the example library on my device with the Gboard enabled, I then deleted all of the text from the textView and started typing a sentence. Only the first letter was capitalized. Assuming I tested this properly I believe this is fixed but I wanted to confirm with you to see if there's something additional I should be testing.

@szweier szweier self-assigned this Mar 24, 2019
@szweier szweier closed this as completed Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants