Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cache mechanism #305

Closed
9 tasks done
szyb opened this issue Jun 17, 2022 · 3 comments · Fixed by #308
Closed
9 tasks done

Improve cache mechanism #305

szyb opened this issue Jun 17, 2022 · 3 comments · Fixed by #308
Assignees
Milestone

Comments

@szyb
Copy link
Owner

szyb commented Jun 17, 2022

Due to the large increase in inquiries to Synopackage we need to improve our cache mechanism to minimize number of requests to the source servers. For now, caching responses from the servers is setup for CPU & DSM version (build number) & channel (stable/bet) and expiration is set to 10h.

  • Cache expiration should be able to be set per repository as well as globally. This should be released as soon as possible.
  • Fix health checks
  • Caching per CPU, DSM version & channel might not be accruable to all repositories. This might be changed (need to investigate first)
  • Add header If-Modified-Since for every GET request
  • Consider using DSM major[.minor] version (instead of build number) to cache responses
  • GET request to the server should be default HTTP method (not related to the issue, but it can be done together)
  • Store cache files in separate folders for different sources
  • Add worker to create cache subfolders (when above checkpoint will be completed)
  • Add cleanup worker (on startup) to remove cached files older than X days for active repositories (leave cache files for inactive sources - if any)
@szyb szyb self-assigned this Jun 17, 2022
@szyb szyb added enhancement New feature or request Accepted Priority-high labels Jun 17, 2022
@szyb szyb added this to the v1.1 milestone Jun 17, 2022
szyb added a commit that referenced this issue Jun 18, 2022
…erver

Will be replaced by more robust solution (issue #305)
@szyb
Copy link
Owner Author

szyb commented Jun 20, 2022

A temprorary hack for filebot has been deployed with 1.0.7 version

@szyb
Copy link
Owner Author

szyb commented Jun 28, 2022

GET request to the server should be default HTTP method (not related to the issue, but it can be done together) is not accurate for all (legacy) repositories

@szyb
Copy link
Owner Author

szyb commented Jun 28, 2022

" Add header If-Modified-Since for every GET request" will be part of #289

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant