Add test for statistics logic #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halfwhole
force-pushed
the
time-series-admin-logic-test
branch
from
c138f90
to
9a1b7d9
Compare
|
Ok amended |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if what I'm doing is entirely correct!
For the
setFeedbackResponseStatistic(Instant time, int totalCount)method, is thetotalCountmeant to be the entire total number of feedback responses there have been in history?So if the previous total count from yesterday's statistic was 10, and now I want to add 3 new counts, should I call the
setFeedbackResponseStatisticmethod with the current time andtotalCount = 13?