Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional argument 'time_label' to 'timeline_slider' #22

Closed

Conversation

TomNicholas
Copy link
Contributor

Allows you to have a timeline which has a label other than "Time". Useful for when you want to animate your data over a non-temporal dimension, e.g. space.

Implemented as an optional argument to 'timeline_slider()', so usage looks like:

anim.controls(timeline_slider_args={'time_label': 'x position'})

Not sure if this should instead be implemented as an extra attribute on the timeline?

@t-makaro
Copy link
Owner

Thanks. This feature was already added in 0.3.0 as an argument named "text". It appears that you are working with an older version of animatplot (you'll need to rebase your github fork).

@t-makaro t-makaro closed this Nov 27, 2018
@TomNicholas TomNicholas deleted the arbitrary_slider_label branch November 28, 2018 01:15
@TomNicholas
Copy link
Contributor Author

Ah okay, great!

Are the possible arguments to timeline_slider and controls in the documentation? I was definitely looking at the most recent version of those...

@t-makaro
Copy link
Owner

Yup. under Animation.timline_slider.

timeline_slider(text='Time', ax=None, valfmt='%1.2f', color=None, axis=None)

Parameters: 
    text (str, optional) – The text to display for the slider. Defaults to ‘Time’
    ...

There was also a note in the changelog that mentioned it broke backwards compatibility with other positional arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants