Ruida driver speed conversion wrong?

[mgmax]

The ruida driver converts speeds 0-100% to 0-1000mm/s. This value is hardcoded, even though the driver has settings for "Max vector cutting speed (mm/s)" and "Max vector move speed (mm/s)". These settings currently have no effect.

Do all Ruida machines have a limit of 100% = 1000 mm/s?

If yes, these settings should probably be removed.
To do so, remove everything related to MaxVector... and MAX_VECTOR_... except for the one line where the class attribute is declared. To avoid that importing old settings fails, do not remove the attribute but mark it as @Deprecated transient , as in

LibLaserCut/src/main/java/de/thomas_oster/liblasercut/drivers/LaserToolsTechnicsCutter.java

Lines 238 to 244 in bc3f413

	// This variable is ignored, must not be removed to ensure compatibility
	// with imported old settings (before August 2020).
	@Deprecated
	transient protected boolean flipXaxis = false;
	// This variable is only for compatibility with imported old settings:
	@Deprecated
	transient protected boolean flipYaxis = true;

If no, then the conversion should depend on the configured speed. speed_mmps = speed_percent * max_speed / 100

Originally posted by @mgmax in #186 (comment)

[fblaese]

The speed hardware limit is configurable via RDWorks. Instead of removing this setting, it should be utilized for the speed conversion.
I will send a Pull Request for this (and a few other improvements) soon.

On a side note: I think that setting the speed as a percentage of the machine limits is quite counterintuitive. I would prefer an absolute speed setting in mm/s, which is automatically confined to the machine limits.

[mgmax]

Currently, VisiCut / LibLaserCut uses relative speeds for every driver. In the long term, this should be switchable, see t-oster/VisiCut#381 for details. In the short term, drivers must use relative speeds as input.