-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add absolute speed option for Smoothieboard driver #63
Conversation
794a9b5
to
233ba3f
Compare
233ba3f
to
d1957b5
Compare
As this is also applicable to all other GenericGcode based drivers, it would perhaps be better to make this a configuration option inside GenericGcodeDriver, named something like "Absolute speed (change will break existing settings)". It would also make the code easier to understand, if setSpeed just contains an if/else logic. The configuration dialog even allows changing the driver, so we cannot prevent the user from switching the option anyway. The Epilog driver is not based on Gcode, so it would still work as before. |
I don't like having an option break all the profiles, especially when you can't then tell which ones have been updated. But I'm not happy with having multiple drivers either. The option needs to either auto-update the profiles, or just change how they're displayed. I'll look at doing the latter. Also, I made the driver immutable a while back, because you couldn't safely change it then change it back without losing some of the settings. And it happened immediately, so hitting "Cancel" didn't fix it. |
Cool feature, I'd be very interested in having this as a general option for all gcode drivers. |
I am not sure, if it is such a problem that it breaks the profiles, because if you are messing with the driver settings, you should know what you are doing anyway... |
It's still a UI failure. And fixing those has been the main focus of my work on VisiCut. |
Hi, what is the state of this patch? I think adding it to the generic gcode driver is a good option |
I'm not happy with it, and I didn't get far trying to resolve the issues that popped up. The big one was that the displayed text for the "power/speed/focus" options is magic and used as a key for serialisation. So I couldn't readily just change those dynamically to include units, because it breaks everything. It did occur to me you can be super sneaky and just change the max speed in the driver to 6000 mm/min, at which point the percentage is also numerically identical to the speed in mm/s... |
but it will only allow values between 0 and 100, right? |
It's just a trick, not really a good solution :) |
I'm having another stab at this, although the implementation is significantly different now - so I'll close this PR and raise a new one if/when I get it working. |
Adds new Smoothie driver that changes the meaning of the Speed variable from percent to mm/min.
Needs more work, don't merge just yet.
t-oster/VisiCut#381