Have to call stream.finish() with GZipOutputStream

[twinforces]

GZipOutputStream doesn't always return good results if you don't call stream.finish() before calling stream.close(). Weird, buggy, but true.

[twinforces]

Here's a link:

http://wondersofcomputing.blogspot.com/2010/02/gzipoutputstream-remember-to-finish.html

Note that the javadocs for GZipOutputStream show the finish() call as well.

[t0xa]

Thanks. Will do.

[t0xa]

Added.

[twinforces]

Hey, I have some other changes if you're interested to both simplify the code and make it work with non-blocking I/O. I didn't do it inside gelfj because I needed a Spring bean GelfSender, but let me know and I'll back port them to gelfj.

Added.

---

Reply to this email directly or view it on GitHub:
#21 (comment)