Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide result value #26

Closed
wants to merge 2 commits into from
Closed

Conversation

sfriedsam
Copy link

No description provided.

@sfriedsam sfriedsam closed this Dec 10, 2015
@t1
Copy link
Owner

t1 commented Jul 2, 2017

@sfriedsam: I just re-found this PR and I simply forgot why you had added and then closed it again. Could you please call it to my mind again?

@sfriedsam
Copy link
Author

sfriedsam commented Jul 2, 2017

@t1 : We thought about using t1 logging-interceptor in one of our customer applications. Because of privacy (and data volume) we needed a way to suppress the "return value" in our log-files. But we still would liked to use the "response time" value to measure and analyze our application.
You asked me to close the PR, because the "boolen flag way" could lead to an ambiguity API.

@t1
Copy link
Owner

t1 commented Jul 2, 2017

@sfriedsam: thanks for the memory refresh. #11 would fix this issue and #19 would even be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants