Fixes & updates #47
Merged
Fixes & updates #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cannot mix If statement with values, needs to run in it's own shell
Cannot mix If statement with values, needs to run in it's own shell
Updated and functional ChangeLockscreenImage.ps1 for the latest app update
Fixes and updates
|
KB5036979 windows update breaks ChangeLockscreenImage.ps1, but latest update to WDD supports that function natively. ChangeLockscreenImage.ps1 can be safely removed. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
t1m0thyj
requested changes
Apr 27, 2024
There was a problem hiding this comment.
@dariusz-goc Thanks for fixing these scripts!
As you mentioned the ChangeLockscreenImage script is obsolete now that WDD supports that function natively. Please remove the ChangeLockscreenImage.ps1 script and I will approve 🙂
Also, some users have reported issues with the native lockscreen functionality in WDD, please let me know if you do as well: t1m0thyj/WinDynamicDesktop#548
|
I think I managed to remove the file. Please review again. |
t1m0thyj
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed for latest app version:
Updated legacy script: