Graph fix, Add Movies Individually, Add released movies to a draft #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull from t2t2/draft
…upt assumption Removed the Admin::HomeController to AdminController due to issues with the Admin namespace Added the ability to add a movie given the box office mojo id, including its earnings to date. Added the ability to add an already released movie to a league, a warning is shown to the user in this case. Added an admin movie list for debugging purposes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't write an actual scraper, but added a form for Admins to add movies individually, and add them retroactively to the draft. Our draft was done last week and some of the movies released this weekend.
Hoping that if you take this code you'll add me as an admin so I can add the movies that are missing from my draft and get it started, then I don't need to bug you if a movie is missing (or 10)
Full List of changes:
-Rewrite graph logic because the original logic was based on an incorrupt assumption
-Removed the Admin::HomeController to AdminController due to issues with the Admin namespace
-Added the ability to add a movie given the box office mojo id, including its earnings to date.
-Added the ability to add an already released movie to a league, a warning is shown to the user in this case.
-Added an admin movie list for debugging purposes.