Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES6 class syntax] lang-updated event listener is not called #43

Closed
t2ym opened this issue Feb 3, 2017 · 1 comment
Closed

[ES6 class syntax] lang-updated event listener is not called #43

t2ym opened this issue Feb 3, 2017 · 1 comment

Comments

@t2ym
Copy link
Owner

t2ym commented Feb 3, 2017

lang-updated event listener is not called on non-legacy ES6 class syntax

Workaround: Imperative listener addition at connectedCallback()

  connectedCallback() {
    super.connectedCallback();
    this.listen(this, 'lang-updated', '_langUpdated');
  }
  _langUpdated(effectiveLang) {
    this.model = deepcopy(this.text.model);
  }

Workaround 2: Use observers instead of listeners

  • Be sure to handle the effectiveLang argument properly in the observer
    static config() {
      return {
        observers: [ '_langUpdated(effectiveLang)' ]
      }
    }
    _langUpdated(effectiveLang) {
      this.model = deepcopy(this.text.model);
    }
@t2ym
Copy link
Owner Author

t2ym commented Feb 3, 2017

Does this issue mean config.listeners is deprecated?

Polymer/polymer#4173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant