Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to add more attribute to xliff template #29

Merged
merged 2 commits into from Jun 20, 2018

Conversation

vanvo1605
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jun 12, 2018

Coverage Status

Coverage decreased (-0.3%) to 99.721% when pulling c518af2 on vanvo1605:master into 2d2478a on t2ym:master.

@t2ym
Copy link
Owner

t2ym commented Jun 12, 2018

@vanvo1605 Can you add tests to your changes? Coverage falls down by -6.77% with your changes due to the missing coverage in your added codes below. Thank you.

https://coveralls.io/builds/17441387/source?filename=xliff-conv.js#L680

Note:

  • Failures of tests due to the incorrect Sauce Labs credentials in your pull requests should be fixed automatically after the changes are merged into the master branch.

@vanvo1605
Copy link
Contributor Author

Hi @t2ym, I updated something and added test for changes. Could you please help to review it?
c518af2
Thanks.

@t2ym t2ym merged commit 73b81a7 into t2ym:master Jun 20, 2018
@vanvo1605
Copy link
Contributor Author

vanvo1605 commented Jun 20, 2018 via email

t2ym added a commit that referenced this pull request Jun 20, 2018
t2ym added a commit that referenced this pull request Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants