Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): wrap div that follow docs direction around the code elements #1051

Merged

Conversation

Sboonny
Copy link
Contributor

@Sboonny Sboonny commented Jan 5, 2023

Closes #1037

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

  • removed tailwind classes from global.css
  • wrapped div around code elements
  • add tailwind classes to the div element

Screenshots

image

💯

@changeset-bot
Copy link

changeset-bot bot commented Jan 5, 2023

⚠️ No Changeset found

Latest commit: 51b5500

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 18, 2023 at 10:37PM (UTC)

@github-actions github-actions bot added the 📚 documentation Improvements or additions to documentation label Jan 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 77
🟢 Accessibility 100
🟢 Best practices 100
🟠 SEO 86
🟠 PWA 54

Lighthouse ran on https://create-t3-app-git-fork-sboonny-feat-wrap-border-a-10de30-t3-oss.vercel.app/

www/src/styles/global.css Outdated Show resolved Hide resolved
Co-authored-by: Muhammed Mustafa <muhammed@freecodecamp.org>
@Sboonny Sboonny deleted the feat/wrap-border-around-code-elements branch January 19, 2023 00:12
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: border-width around code element breaks in the wrong direction in the docs
2 participants