Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: override default config files #1091

Closed
wants to merge 2 commits into from

Conversation

NathanPip
Copy link
Contributor

simple config override options for cli

regex match tailwind file extension

add lint rule to remove invalid end of line linting error

Closes #

βœ… Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

A simple implementation of config overrides in the cli using --flags.
--twConfig [path] overrides default tailwind config if valid path is provided and file is present
--tsConfig [path] overrides default typescript config if valid path is provided and file is present

Screenshots

[Screenshots]
image

πŸ’―

simple config override options for cli

regex match tailwind file extension

add lint rule to remove invalid end of line linting error
@changeset-bot
Copy link

changeset-bot bot commented Jan 16, 2023

⚠️ No Changeset found

Latest commit: fc0d27f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 16, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated
create-t3-app βœ… Ready (Inspect) Visit Preview πŸ’¬ Add your feedback Jan 17, 2023 at 11:43PM (UTC)

@github-actions github-actions bot added πŸ“Œ area: cli Relates to the CLI πŸ“š documentation Improvements or additions to documentation labels Jan 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2023

⚑️ Lighthouse report for the changes in this PR:

Category Score
🟒 Performance 100
🟒 Accessibility 100
🟒 Best practices 100
🟠 SEO 86
🟠 PWA 54

Lighthouse ran on https://create-t3-app-git-fork-nathanpip-cli-override-options-t3-oss.vercel.app/

@juliusmarminge
Copy link
Member

As mentioned on the original issue, I think it should just be a single flag and then we can match the name of the file.

Ideally we'd support overriding any file too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ“Œ area: cli Relates to the CLI πŸ“š documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants