-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve start-databse scripts exit and messages #1816
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@kasbah is attempting to deploy a commit to the t3-oss Team on Vercel. A member of the Team first needs to authorize it. |
-e MYSQL_ROOT_PASSWORD="$DB_PASSWORD" \ | ||
-e MYSQL_DATABASE=project1 \ | ||
-p 3306:3306 \ | ||
docker.io/mysql && echo "Database container '$DB_CONTAINER_NAME' was successfully created" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why && here and not just run it on it's own line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's so that it doesn't lie and print "successfully created" if the docker command fails. You could put it on its own line and check the exit status or set -e
for the entire script but this actually seems simpler and clearer.
✅ Checklist
Changelog