Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated --dbProvider CI flag to parse configured databases #1865 #1867

Merged
merged 11 commits into from
May 7, 2024

Conversation

xelacast
Copy link
Contributor

@xelacast xelacast commented May 4, 2024

Closes #1865

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

Inside cli/src/cli/index.ts

Updated CI flags to include dbProvider with a default value of 'sqlite'
Updated default value of --dbProvider
Included an error check for the input of the --dbProvider value
Set cliResults.databaseProvider to a conditional value based on the user input
Included parser for both Drizzle and Prisma

Updated documentation to include CLI flags and examples

Feedback or advice is encouraged 💯

💯

Copy link

changeset-bot bot commented May 4, 2024

🦋 Changeset detected

Latest commit: d2e3c89

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 8:20am

Copy link

vercel bot commented May 4, 2024

@xelacast is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

@xelacast xelacast changed the title fix: parsed --dbContainer CI flag for configured dbs #1865 (Please delete. I drafted the wrong branch to merge) May 4, 2024
@xelacast xelacast changed the title (Please delete. I drafted the wrong branch to merge) fix: updated --dbProvider CI flag to parse configured databases #1865 May 4, 2024
@xelacast
Copy link
Contributor Author

xelacast commented May 4, 2024

GitHub Actions error that I cannot reproduce. The error is here.

LibsqlError: URL_SCHEME_NOT_SUPPORTED: The client supports only "libsql:", "wss:", "ws:", "https:", "http:" and "file:" URLs, got "mysql:". For more information, please read https://github.com/libsql/libsql-client-ts#supported-urls

I will be trying to solve this but If anyone has any insight on why this is happening it would be much appreciated.

EDIT: 05/06/24 The GitHub action e2e error happens once I make the logic for the databaseProvider = cliResults.flags.dbProvider statement on line 200 in cli/src/cli/index.ts. I cannot reproduce this error on my own machine only with the github action e2e.yaml.

@xelacast xelacast marked this pull request as ready for review May 4, 2024 16:00
Copy link
Member

@juliusmarminge juliusmarminge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

ps: sorry for the weird CI issue...

@juliusmarminge juliusmarminge added this pull request to the merge queue May 7, 2024
@juliusmarminge juliusmarminge removed this pull request from the merge queue due to a manual request May 7, 2024
@juliusmarminge juliusmarminge merged commit 304a67f into t3-oss:main May 7, 2024
266 of 267 checks passed
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: CLI Option for Postgres
2 participants