Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove next-auth checks for node 18 and next 13 #673

Merged
merged 6 commits into from Nov 4, 2022
Merged

feat: remove next-auth checks for node 18 and next 13 #673

merged 6 commits into from Nov 4, 2022

Conversation

c-ehrlich
Copy link
Member

@c-ehrlich c-ehrlich commented Oct 31, 2022 •
edited

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

  • remove checks for Node 18
  • remove checks for Next 13
  • require at least Next-Auth 4.15.1

💯

@vercel
Copy link

vercel bot commented Oct 31, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
create-t3-app ✅ Ready (Inspect) Visit Preview Nov 4, 2022 at 2:17PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2022 •
edited

🦋 Changeset detected

Latest commit: 9fcb40f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App labels Oct 31, 2022
@c-ehrlich c-ehrlich changed the title Draft: Next auth stuff feat: remove next-auth checks for node 18 and next 13 Oct 31, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022 •
edited

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 100
🟢 Accessibility 98
🟢 Best practices 93
🟠 SEO 86
🟠 PWA 54

Lighthouse ran on https://create-t3-app-git-next-auth-stuff-t3-oss.vercel.app/

@c-ehrlich c-ehrlich marked this pull request as ready for review November 4, 2022 09:57
This was referenced Nov 4, 2022
Closed
Closed
@juliusmarminge juliusmarminge added the 🚀 autorelease add this label to a pr to trigger a beta release label Nov 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

A new create-t3-app prerelease is available for testing. You can install this latest build in your project with:

npx create-t3-app@6.0.0-beta.89f7b85

@github-actions github-actions bot removed the 🚀 autorelease add this label to a pr to trigger a beta release label Nov 4, 2022
juliusmarminge
juliusmarminge approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@juliusmarminge juliusmarminge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on beta

@juliusmarminge juliusmarminge enabled auto-merge (squash) November 4, 2022 14:17
@juliusmarminge juliusmarminge merged commit 44a107b into next Nov 4, 2022
@juliusmarminge juliusmarminge deleted the next-auth-stuff branch November 4, 2022 14:18
@github-actions github-actions bot mentioned this pull request Nov 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusmarminge juliusmarminge juliusmarminge approved these changes

@nexxeln nexxeln Awaiting requested review from nexxeln

@t3dotgg t3dotgg Awaiting requested review from t3dotgg

Assignees
No one assigned
Labels
📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@c-ehrlich @juliusmarminge