Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: minor fixes #748

Merged
merged 5 commits into from
Nov 16, 2022
Merged

docs: minor fixes #748

merged 5 commits into from
Nov 16, 2022

Conversation

AyanavaKarmakar
Copy link
Contributor

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

  • TailwindCSS => Tailwind CSS in landing page stack

image

  • Added a space after ... to decongest.
  • there's => there're. Lemme know if that's alright, will revert otherwise.

Screenshots

  • Before

image

  • After

image

  • Before

image

  • After

image

💯

@changeset-bot
Copy link

changeset-bot bot commented Nov 16, 2022

⚠️ No Changeset found

Latest commit: e844c38

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
create-t3-app ✅ Ready (Inspect) Visit Preview Nov 16, 2022 at 1:33PM (UTC)

@github-actions github-actions bot added the 📚 documentation Improvements or additions to documentation label Nov 16, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 100
🟢 Accessibility 98
🟢 Best practices 93
🟠 SEO 86
🟠 PWA 54

Lighthouse ran on https://create-t3-app-git-fork-ayanavakarmakar-next-t3-oss.vercel.app/

Copy link
Member

@nexxeln nexxeln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make it there there are. Rest looks good

@nexxeln nexxeln merged commit c701a83 into t3-oss:next Nov 16, 2022
@AyanavaKarmakar AyanavaKarmakar mentioned this pull request Nov 17, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants