New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: ignore next-env.d.ts #786
chore: ignore next-env.d.ts #786
Conversation
π¦ Changeset detectedLatest commit: faa2821 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
Then we can remove this part in the docs maybe? https://create.t3.gg/en/folder-structure#next-envdts cc @nexxeln |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure the docs are incorrect here. This file is required for TypeScript to work in Next.js and it should not be removed or edited. So if someone clones a project they would have to make this file on their own.
In the latest create-next-app as well this is added and committed in the initial commit.
It's generated everytime you run dev or build |
Oh I didn't know that. But then why does create-next-app put it in initial commit? |
I just created new I can only assume it's copied to the new project to avoid surprises from sudden file appearance. |
Ah okay that makes sense. |
It's still a file that is being generated, so I think we should keep it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
β‘οΈ Lighthouse report for the changes in this PR:
Lighthouse ran on https://create-t3-app-git-fork-skuridin-chore-next-env-gitignore-t3-oss.vercel.app/ |
β Checklist
Changelog
Added
next-env.d.ts
to.gitignore
as recommended in Next.js documentation.Screenshots
π―