Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removing redundant optional chaining in templates #800

Merged
merged 3 commits into from Nov 18, 2022

Conversation

HatulaPro
Copy link
Contributor

Closes #

βœ… Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

Removed the optional chaining on sessionData. It is already verified at the start of the line.


πŸ’―

@changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2022

πŸ¦‹ Changeset detected

Latest commit: 8579897

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 18, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
create-t3-app βœ… Ready (Inspect) Visit Preview Nov 18, 2022 at 7:43PM (UTC)

@github-actions github-actions bot added πŸ“Œ area: cli Relates to the CLI πŸ“Œ area: t3-app Relates to the generated T3 App labels Nov 18, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2022

⚑️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 78
🟒 Accessibility 100
🟒 Best practices 100
🟠 SEO 86
🟠 PWA 54

Lighthouse ran on https://create-t3-app-git-fork-hatulapro-next-t3-oss.vercel.app/

@juliusmarminge juliusmarminge merged commit d5d5a2f into t3-oss:next Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ“Œ area: cli Relates to the CLI πŸ“Œ area: t3-app Relates to the generated T3 App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants