-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add notes about env vars #869
Conversation
🦋 Changeset detectedLatest commit: b83762c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion the comment on gitignore is fine, but please not in t3 axioms. I suggest you add it in our env variables docs
Tbh thinking this is important enough to be an axiom is kinda hilarious to me |
Thank you, I occasionally try to be hilarious |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://create-t3-app-git-fork-meech-ward-next-t3-oss.vercel.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good now remove it from the T3 axioms and we can merge
I did, the only change exists in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry missed that. Looks good to me!
Actually we can also add a comment in the env file with a link to our env docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* docs: add notes about env vars * Add note about not comitting env files * Create early-coats-stare.md Co-authored-by: Shoubhit Dash <shoubhit2005@gmail.com>
Closes #304
✅ Checklist
Changelog
Add a note about opinions surrounding
.env
files and the reason for the departure from next's oppinions.