Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(RTL): search modal spacing issue #954

Merged
merged 5 commits into from
Dec 15, 2022
Merged

fix(RTL): search modal spacing issue #954

merged 5 commits into from
Dec 15, 2022

Conversation

Sboonny
Copy link
Contributor

@Sboonny Sboonny commented Dec 11, 2022 •
edited
Loading

Closes #

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

[Mirrored the spacing in the original search modal for the RTL search modal]

Screenshots

Original search modal

image

RTL search modal

image

💯

Edit: I had to move this to draft, because I noticed a second alignment issue with the footer

@changeset-bot
Copy link

changeset-bot bot commented Dec 11, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: ef55474

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 11, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
create-t3-app ✅ Ready (Inspect) Visit Preview Dec 15, 2022 at 8:28PM (UTC)

@github-actions github-actions bot added the 📚 documentation Improvements or additions to documentation label Dec 11, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2022 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟢 Best practices 100
🟠 SEO 86
🟠 PWA 54

Lighthouse ran on https://create-t3-app-git-fork-sboonny-search-bar-alignme-0152fb-t3-oss.vercel.app/

@Sboonny Sboonny marked this pull request as draft December 11, 2022 02:33
@Sboonny Sboonny changed the title fix(RTL): search icon alignment issue fix(RTL): search modal alignment issue Dec 11, 2022
@Sboonny Sboonny marked this pull request as ready for review December 11, 2022 02:42
@Sboonny Sboonny changed the title fix(RTL): search modal alignment issue fix(RTL): search modal spacing issue Dec 11, 2022
@c-ehrlich
Copy link
Member

spacing looks good!

does it maybe make sense to force this section to be ltr?
image

@Sboonny
Copy link
Contributor Author

Sboonny commented Dec 11, 2022

spacing looks good!

does it maybe make sense to force this section to be ltr? image

Nice catch. Yeab it should, because it isn't translatable currently, It should be LTR 👍

c-ehrlich
c-ehrlich approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@c-ehrlich c-ehrlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@c-ehrlich c-ehrlich merged commit a84dce4 into t3-oss:next Dec 15, 2022
@Sboonny Sboonny deleted the search-bar-alignment-issue branch December 16, 2022 02:10
@JohnBakhmat JohnBakhmat mentioned this pull request Dec 26, 2022
Merged
3 tasks
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app that referenced this pull request Jun 9, 2024
@c-ehrlich
fix(RTL): search modal spacing issue (t3-oss#954)
d605dbc 
* fix: RTL search bar alignment issue

* fix the spacing issue in the footer of the modal

* Revert the logo direction if the page is RTL

Co-authored-by: Christopher Ehrlich <ehrlich.christopher@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-ehrlich c-ehrlich c-ehrlich approved these changes

@juliusmarminge juliusmarminge Awaiting requested review from juliusmarminge

@nexxeln nexxeln Awaiting requested review from nexxeln

@t3dotgg t3dotgg Awaiting requested review from t3dotgg

Assignees
No one assigned
Labels
📚 documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Sboonny @c-ehrlich