-
-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use bun as package manager #609
Conversation
.github/workflows/ci.yml
Outdated
- name: Get pnpm store directory | ||
id: pnpm-cache | ||
run: | | ||
echo "pnpm_cache_dir=$(pnpm store path)" >> $GITHUB_OUTPUT | ||
|
||
- name: Setup pnpm cache | ||
uses: actions/cache@v3 | ||
with: | ||
path: ${{ steps.pnpm-cache.outputs.pnpm_cache_dir }} | ||
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }} | ||
restore-keys: | | ||
${{ runner.os }}-pnpm-store- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For those lurking this PR, there are a few features that I would like to see supported in Bun before I can recommend it over pnpm:
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @juliusmarminge and the rest of your teammates on Graphite |
Related issues in the bun repo: oven-sh/bun#5793 This might be a workaround:
Although I believe it would not support wildcard paths.
Possible workaround:
Although these workarounds might work, it's probably best to wait for any official bun support for filtering workspaces and patching. |
Hello @juliusmarminge, Is this PR still a work in progress or is it going to be dropped ? |
These things are still not there + there's some weird quirks with Bun + Turborepo so for now we're "stuck" with pnpm |
Thanks for your super fast reply :) |
gonna close this - bun workspaces still feel quite far out to being production ready imo and the bun package manager doesn't seem to get enough love by the team to suggest we'll get there in the near future |
@juliusmarminge - does it mean that |
i don't control the |
Might be a bit unresponsible to use it right away, but seems like a straight forward migration.