Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove any type #122

Merged
merged 4 commits into from
Oct 16, 2023
Merged

Conversation

chungweileong94
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Sep 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
t3-env ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2023 7:06am

@vercel
Copy link

vercel bot commented Sep 5, 2023

@chungweileong94 is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

@@ -61,7 +61,7 @@ export function createEnv<
>(opts: Options<TServer, TClient, TShared>) {
const client = typeof opts.client === "object" ? opts.client : {};
const server = typeof opts.server === "object" ? opts.server : {};
const shared = typeof opts.shared === "object" ? opts.shared : {};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this begs the question why are we doing this check for client/server ? the core package handles that already 🤔

const _client = typeof opts.client === "object" ? opts.client : {};
const _server = typeof opts.server === "object" ? opts.server : {};
const _shared = typeof opts.shared === "object" ? opts.shared : {};

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juliusmarminge juliusmarminge merged commit 632d183 into t3-oss:main Oct 16, 2023
2 of 4 checks passed
@chungweileong94 chungweileong94 deleted the remove-any-type branch October 16, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants