Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make runtimeEnv optional in Next.js and default to process.env #75

Merged
merged 9 commits into from
Jun 25, 2023

Conversation

juliusmarminge
Copy link
Member

Closes #71

@vercel
Copy link

vercel bot commented May 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
t3-env ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2023 3:45pm

@github-actions
Copy link
Contributor

A new canary is available for testing. You can install this latest build in your project with:

pnpm add @t3-oss/env-core@0.4.1-canary.40f9204

or, if you're using Next.js:

pnpm add @t3-oss/env-nextjs@0.4.1-canary.40f9204

or, if you're using Nuxt:

pnpm add @t3-oss/env-nuxt@0.4.1-canary.40f9204

@juliusmarminge
Copy link
Member Author

Hmm client variables are not automatically defined 🤔

CleanShot 2023-05-30 at 12 57 40

@juliusmarminge
Copy link
Member Author

@chungweileong94 What do you think of this?

@github-actions
Copy link
Contributor

A new canary is available for testing. You can install this latest build in your project with:

pnpm add @t3-oss/env-core@0.4.2-canary.6984043

or, if you're using Next.js:

pnpm add @t3-oss/env-nextjs@0.4.2-canary.6984043

or, if you're using Nuxt:

pnpm add @t3-oss/env-nuxt@0.4.2-canary.6984043

@juliusmarminge juliusmarminge merged commit 8568a9b into main Jun 25, 2023
3 checks passed
@juliusmarminge juliusmarminge deleted the optional-runtime branch June 25, 2023 17:34
@chungweileong94
Copy link
Contributor

@chungweileong94 What do you think of this?

LGTM, even though the experimental__runtimeEnv looks a bit ambiguous, and I can't think of anything else as of now. But things could be changed/improved overtime, especially if Vercel decided to do the same thing on client🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't require destructure of process.env in Next.js
2 participants