Add error handling

t32k · Apr 5, 2014 · 48b34ac · 48b34ac
1 parent d4dea67
commit 48b34ac
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 6 deletions.
diff --git a/lib/parser.js b/lib/parser.js
@@ -36,6 +36,7 @@ function requestSync(options) {
  * @constructor
  */
 function Parser(urls, files, styles, options) {
+
     this.urls = urls;
     this.files = files;
     this.styles = styles;
@@ -198,12 +199,7 @@ Parser.prototype.parse = function(callback) {
 
         // parse css string
         var rawRules = [];
-
-        try {
-            rawRules = cssParse(parsedData.cssString).stylesheet.rules;
-        } catch (error) {
-            throw error;
-        }
+        rawRules = cssParse(parsedData.cssString).stylesheet.rules;
 
         // add rules into result
         rawRules.forEach(function(rule) {

diff --git a/lib/stylestats.js b/lib/stylestats.js
@@ -77,6 +77,10 @@ function StyleStats(args, config) {
     }
 
     this.options = _.extend({}, defaultOptions, customOptions);
+
+    if (_.isEmpty(this.urls) && _.isEmpty(this.files) && _.isEmpty(this.styles)) {
+        throw new Error('Invalid argument: [' + args + ']');
+    }
     this.parser = new Parser(this.urls, this.files, this.styles, this.options);
 }
 

diff --git a/test/stats-test.js b/test/stats-test.js
@@ -82,6 +82,18 @@ describe('Customize with configuration file', function() {
     });
 });
 
+describe('Invalid argument', function() {
+    it('should throw erroe', function(done) {
+        assert.throws(
+            function() {
+                new StyleStats('xxxxxxxxxxxxxxxx');
+            },
+            Error
+        );
+        done();
+    });
+});
+
 describe('Customize with option', function() {
     it('should return gzipped size', function(done) {
         var customObjectStats = new StyleStats('test/fixture/test.css', {