Update v7.0 #155
Merged
Update v7.0 #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danez
approved these changes
Nov 23, 2016
1000ch
reviewed
Dec 29, 2016
| "template-curly-spacing": "error", | ||
| "yield-star-spacing": "error" | ||
| } | ||
| } |
There was a problem hiding this comment.
Use xo instead of eslint and its config.
| console.log(JSON.stringify(result, null, 2)); | ||
| }); | ||
| stats.parse() | ||
| .then(function(result) { |
| const StyleStats = require('../lib/stylestats'); | ||
| const Format = require('../lib/format'); | ||
| const specs = require('../lib/specs'); | ||
| const util = require('../lib/util'); |
There was a problem hiding this comment.
util and fotmat should be exposed as property of stylestats.
This requires refactoring.
There was a problem hiding this comment.
Next time! I believe you can do that :)
| const path = require('path'); | ||
| const json2csv = require('json2csv'); | ||
| const Table = require('cli-table'); | ||
| const Handlebars = require('handlebars'); |
There was a problem hiding this comment.
How custom template feature used? Can be dropped?
| callback(JSON.stringify(this.data, null, 2)); | ||
| }; | ||
| toJSON() { | ||
| return JSON.stringify(this.context, null, 2); |
There was a problem hiding this comment.
Followed sample codes on the official site.
| // they will be joined into css string | ||
| this.cssFiles.forEach((cssFile) => { | ||
| // push local css data | ||
| that.styles.push(fs.readFileSync(cssFile, { |
| * @returns {Promise} | ||
| */ | ||
| parse() { | ||
| const that = this; |
| statsResult = result; | ||
| done(); | ||
| }).catch(function(error){ | ||
| throw error; |
# The first commit's message is: Fix configs # This is the 2nd commit message: Update travis.yml # This is the 3rd commit message: Update travis.yml # Please enter the commit message for your changes. Lines starting # with '#' will be kept; you may remove them yourself if you want to. # An empty message aborts the commit. # # Date: Fri Dec 30 03:39:38 2016 +0900 # # interactive rebase in progress; onto 0eb5246 # Last commands done (5 commands done): # s f0e8d8c Update travis.yml # s 26b63d2 Update travis.yml # Next commands to do (5 remaining commands): # pick 62f7344 Drop handlebars # pick 25c59b4 Add prettify flag # You are currently editing a commit while rebasing branch 'v7.0' on '0eb5246'. # # Changes to be committed: # modified: .travis.yml # modified: package.json #
# The first commit's message is: Add prettify flag # This is the 2nd commit message: Update Readme # Please enter the commit message for your changes. Lines starting # with '#' will be kept; you may remove them yourself if you want to. # An empty message aborts the commit. # # Date: Fri Dec 30 04:42:23 2016 +0900 # # interactive rebase in progress; onto 0eb5246 # Last commands done (8 commands done): # pick 25c59b4 Add prettify flag # s 1bd4496 Update Readme # Next commands to do (2 remaining commands): # pick bed2b91 Add prettify method # pick 6a98da4 Use this keyword # You are currently editing a commit while rebasing branch 'v7.0' on '0eb5246'. # # Changes to be committed: # modified: README.md # modified: bin/cli.js # modified: lib/format.js # modified: lib/stylestats.js #
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prettifyflag and function Prettify data #106