Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't clobber global promise #52

Merged
merged 3 commits into from Jul 25, 2016
Merged

Conversation

sethsamuel
Copy link
Contributor

There's an open thread in es6-promise (stefanpenner/es6-promise#140) to fix this at the library level, but currently the global promise is being clobbered by the "polyfill" even without calling polyfill.

This quick fix avoids that problem.

@sethsamuel
Copy link
Contributor Author

I ended up doing some additional refactoring while getting the tests to pass. Current test failures are due to the travis secret not decoding, I think.

If you'd prefer a more limited PR I can try to pull out just the promise fix.

@t3chnoboy
Copy link
Owner

Looks like something's wrong with my amazon credentials.
Do the tests pass locally?

@sethsamuel
Copy link
Contributor Author

Travis secrets don't unlock on PRs (so the values don't leak to any PR requester). You can run the tests locally with the environment variables set to the AWS secrets and they should pass.

@t3chnoboy t3chnoboy merged commit 3b8c61d into t3chnoboy:master Jul 25, 2016
@t3chnoboy
Copy link
Owner

Awesome! Thank you @sethsamuel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants