onCancel param added #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My version of this solution now includes an updated example. |
|
👍 |
|
In my opinion, there should only be one return callback with a boolean param. Like the actual confirm JS method works. |
|
Will close this since the functionality was added in v0.2.0 through #93. Thanks for the suggestion! |
|
Thanks. Happy to have contributed some thinking to this project. Looks like its being well received. I'll link you to the project I'm using it in when it's live. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a prompt replacement I needed the cancel button to also trigger an action.
I see that my editor has also fixed your odd spacing conventions.