Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved Models to a seperate file, models.py. #240

Merged
merged 4 commits into from May 25, 2019
Merged

Moved Models to a seperate file, models.py. #240

merged 4 commits into from May 25, 2019

Conversation

tBuLi
Copy link
Owner

@tBuLi tBuLi commented May 24, 2019 •
edited

This PR seperates all models from fit.py and places them in a new models.py.

This is just some overdue maintenance, and this PR will introduce no new features.

@tBuLi tBuLi requested a review from pckroon May 24, 2019 08:18
pckroon
pckroon approved these changes May 24, 2019
View reviewed changes
Copy link
Collaborator

@pckroon pckroon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. Next up in the same category: get rid of the core namespace. I don't think it adds anything. Next PR though.

pckroon
pckroon approved these changes May 24, 2019
View reviewed changes
Copy link
Collaborator

@pckroon pckroon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. Next up in the same category: get rid of the core namespace. I don't think it adds anything. Next PR though.

@tBuLi tBuLi merged commit f9e78ae into master May 25, 2019
@tBuLi tBuLi deleted the model_seperation branch May 25, 2019 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pckroon pckroon pckroon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tBuLi @pckroon